Skip to content

Removed the http4client.retain_max_body_size property mentions #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

kkalinin
Copy link
Contributor

@kkalinin kkalinin commented Apr 3, 2020

Description

I've removed the http4client.retain_max_body_size property mentions from documentation and jmeter.properties file.

Motivation and Context

The property is not used anymore and just confuses users.

How Has This Been Tested?

No need to test, only text files modified`

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the [code style][style-guide] of this project.
  • I have updated the documentation accordingly.

@vlsi
Copy link
Collaborator

vlsi commented Apr 3, 2020

@pmouawad , I see the property was removed in 97cc6f4
Do you think it should be completely removed or should it be re-implemented somehow?

@pmouawad
Copy link
Contributor

pmouawad commented Apr 3, 2020

@pmouawad , I see the property was removed in 97cc6f4
Do you think it should be completely removed or should it be re-implemented somehow?

I would prefer to have it re-implemented somehow

@pmouawad pmouawad merged commit b17ac36 into apache:master Oct 1, 2020
kkalinin added a commit to kkalinin/jmeter that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants