-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Use SVG icon for splashscreen #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just in case:
So far it looks like there's no color name that could be used universally for "disabled label foreground". @weisJ, what do you think if a fallback was added to |
I have added the option to add fallback keys. They are declared in the |
So the syntax is either <linearGradient id="Label.disabledForeground"
fallback="textInactiveText Button.disabledText"> or <linearGradient id="Label.disabledForeground"
style="fallback:textInactiveText Button.disabledText"> |
It would be: <linearGradient id="Label.disabledForeground"
fallbackKeys="textInactiveText,Button.disabledText">
<stop offset="0" stop-color="#4d4d4d"/>
<stop offset="1" stop-color="#4d4d4d"/>
</linearGradient> |
Just in case: I've actually tried, and There's no |
Yeah I changed it and forgot about it. |
So far it looks good to me, will commit if there are no objections. |
ace4aca
to
858c4a8
Compare
This change makes the image look better in macOS 2x resolution (e.g. compare the screenshots with #563 ).
I'm not sure we need
.png
logo in case we use.svg
.IntelliJ:

Darcula:

SolarizedLight:

SolarizedDark:

System (macOS):

Motif:

Nimbus:

Metal:

Fallback (in case svg resource is not found):
