Skip to content

Use SVG icon for splashscreen #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Use SVG icon for splashscreen #565

merged 1 commit into from
Mar 19, 2020

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Mar 16, 2020

This change makes the image look better in macOS 2x resolution (e.g. compare the screenshots with #563 ).

I'm not sure we need .png logo in case we use .svg.

IntelliJ:
intellij

Darcula:
darcula

SolarizedLight:
solarizedLight

SolarizedDark:
solarizedDark

System (macOS):
system_mac

Motif:
motif

Nimbus:
nimbus2

Metal:
metal

Fallback (in case svg resource is not found):
fallback_logo

@vlsi
Copy link
Collaborator Author

vlsi commented Mar 16, 2020

Just in case:

  • Label.disabledForeground. It is missing in Nimbus (darklaf converts it to red), and it is white in Motif

  • textInactiveText: missing in Nimbus.

  • ComboBox.disabledForeground: missing in Nimbus. It has a strange color in Metal.

  • Button.disabledText: missing in Motif

So far it looks like there's no color name that could be used universally for "disabled label foreground".

@weisJ, what do you think if a fallback was added to IconColorMapper so it could try multiple colors?
Something like "try Label.disabledForeground, if missing try textInactiveText, if missing try Button.disabledText if missing try Label.foreground, otherwise use #ff0000"?

@weisJ
Copy link
Contributor

weisJ commented Mar 16, 2020

I have added the option to add fallback keys. They are declared in the LinearGradient with fallbackKeys="key1,key2,key3,...". You can try it out with the current master branch of darklaf. The id is still the prioritised key.

@vlsi
Copy link
Collaborator Author

vlsi commented Mar 16, 2020

So the syntax is either

    <linearGradient id="Label.disabledForeground"
                    fallback="textInactiveText Button.disabledText">

or

    <linearGradient id="Label.disabledForeground"
                    style="fallback:textInactiveText Button.disabledText">

@weisJ
Copy link
Contributor

weisJ commented Mar 16, 2020

It would be:

<linearGradient id="Label.disabledForeground"
                fallbackKeys="textInactiveText,Button.disabledText">
   <stop offset="0" stop-color="#4d4d4d"/>
   <stop offset="1" stop-color="#4d4d4d"/>
</linearGradient>

@vlsi
Copy link
Collaborator Author

vlsi commented Mar 16, 2020

Just in case: I've actually tried, and fallbackKeys="textInactiveText,Button.disabledText" does not really work.

There's no keys in weisJ/darklaf@e117205#diff-20761adcf666eb958134331292e43dacR96

@weisJ
Copy link
Contributor

weisJ commented Mar 16, 2020

Yeah I changed it and forgot about it.

@vlsi
Copy link
Collaborator Author

vlsi commented Mar 16, 2020

There's about window:
jmeter_about

I guess should be updated as well

@vlsi
Copy link
Collaborator Author

vlsi commented Mar 16, 2020

IntelliJ

about_light

Darcula:

about_dark

@vlsi
Copy link
Collaborator Author

vlsi commented Mar 16, 2020

So far it looks good to me, will commit if there are no objections.

@vlsi vlsi force-pushed the svg_splash branch 4 times, most recently from ace4aca to 858c4a8 Compare March 16, 2020 14:37
@vlsi vlsi merged commit 024f92b into apache:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants