Skip to content

Bug 64091 - Precise Throughput Timer might produce less samples when low test duration is used #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

Bug 64091 - Precise Throughput Timer might produce less samples when low test duration is used #553

merged 1 commit into from
Jan 27, 2020
+206 −118

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Jan 23, 2020

@codecov-io
Copy link

codecov-io commented Jan 23, 2020 •
edited
Loading

Codecov Report

Merging #553 into master will increase coverage by 0.02%.
The diff coverage is 76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #553      +/-   ##
============================================
+ Coverage      56.1%   56.12%   +0.02%     
- Complexity    10020    10024       +4     
============================================
  Files          1024     1024              
  Lines         62911    62888      -23     
  Branches       7063     7058       -5     
============================================
+ Hits          35297    35298       +1     
+ Misses        25137    25120      -17     
+ Partials       2477     2470       -7
Impacted Files Coverage Δ Complexity Δ
...timers/poissonarrivals/PreciseThroughputTimer.java 10.9% <ø> (ø) 3 <0> (ø) ⬇️
...oissonarrivals/PreciseThroughputTimerBeanInfo.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...issonarrivals/ConstantPoissonProcessGenerator.java 58.57% <73.91%> (+14.95%) 14 <6> (+4) ⬆️
...n/java/org/apache/jmeter/reporters/Summariser.java 84.73% <0%> (-0.77%) 17% <0%> (-1%)
...va/org/apache/jmeter/testbeans/TestBeanHelper.java 29.16% <0%> (+1.38%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5026bc1...82b7dc1. Read the comment docs.

@vlsi vlsi force-pushed the ptt branch 9 times, most recently from b9c88e0 to 4433c62 Compare January 27, 2020 20:57
@vlsi
Bug 64091 - Precise Throughput Timer might produce less samples when …
82b7dc1 
…low test duration is used

This reworks the generation algorithm.
For now the timer generates random numbers in 0..testDuration interval
and sorts them.

Note: the properties of the resulting sequence are still the same,
however the algorithm is NlogN now.
@vlsi vlsi merged commit 03693f7 into apache:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vlsi @codecov-io