Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-11073 : added ensureCapacity method to create hash based collecti… #1722

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

rishabhdaim
Copy link
Contributor

…ons with expected size

@@ -34,6 +36,8 @@
*/
public class CollectionUtils {

private static final int MAX_CAPACITY = 1 << 30;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment here so it's clear why it's needed

Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...but it might be good to explain the capacity limit in a comment

@rishabhdaim rishabhdaim merged commit 5f8fe02 into trunk Sep 17, 2024
1 of 2 checks passed
@rishabhdaim rishabhdaim deleted the OAK-11073 branch September 17, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants