OAK-11129 Improve Lucene documentation #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alagodasii
reviewed
Sep 16, 2024
alagodasii
reviewed
Sep 16, 2024
fabriziofortino
requested changes
Sep 16, 2024
fabriziofortino
approved these changes
Sep 16, 2024
nfsantos
approved these changes
Sep 16, 2024
Comment on lines
492
to
494
| if the node is part of the index, if the node type (or mixin) matches, | ||
| if the mime type property is set, and if the mime type is indexed | ||
| (see the Tika configuration). |
There was a problem hiding this comment.
This would be more clear as a bullet list. Do all of the conditions have to apply for a binary property to be indexed? My understanding is that yes. So it would more clear to say this explicitly, like: if all of the conditions below are true:
|
|
||
| propertyIndex | ||
| : Whether the index for this property is used for equality conditions, ordering, | ||
| and is not null conditions. | ||
| and is not null conditions. Example query: |
There was a problem hiding this comment.
Took me a while to understand what is meant by: and is not null conditions. I guess it should be read as "and is-not-null conditions", right?
There was a problem hiding this comment.
Yes. I'll quote is not null (that is the syntax).
|
|
||
| notNullCheckEnabled | ||
| : Since 1.1.8 | ||
| : If the property is checked for _is not null_ then this should be set to true. | ||
| : If the property is checked for `is not null` then this should be set to true. |
There was a problem hiding this comment.
That's more clear, using quotes for is not null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.