OAK-11138: add test coverage for changing a persisted namespace mappi…

…ng when node exists that uses the prefix (#1735)
apache · Sep 27, 2024 · c4ff3dd · c4ff3dd
1 parent 07ae4da
commit c4ff3dd
Showing 1 changed file with 49 additions and 0 deletions.
diff --git a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
@@ -1996,6 +1996,55 @@ public void testNamespaceRegistry() throws RepositoryException {
         assertFalse(asList(nsReg.getURIs()).contains("file:///foo"));
     }
 
+    @Test
+    public void testUnregisterNamespaceWhenUsed() throws RepositoryException {
+
+        // see OAK-11138
+
+        String testNamespaceName1 = "file:///foo";
+        String testNamespaceName2 = "file:///bar";
+        Session session = getAdminSession();
+
+        NamespaceRegistry nsReg = session.getWorkspace().getNamespaceRegistry();
+        assertFalse(asList(nsReg.getPrefixes()).contains("foo"));
+        assertFalse(asList(nsReg.getURIs()).contains(testNamespaceName1));
+
+        nsReg.registerNamespace("foo", testNamespaceName1);
+        assertTrue(asList(nsReg.getPrefixes()).contains("foo"));
+        assertTrue(asList(nsReg.getURIs()).contains(testNamespaceName1));
+
+        // check that nodes are "same" independent of how retrieved
+        Node x1 = session.getRootNode().addNode("foo:test");
+        session.save();
+        Node x2 = session.getRootNode().getNode("{" + testNamespaceName1 + "}test");
+        assertTrue(x1.isSame(x2));
+
+        // unregister and add with a new name
+        nsReg.unregisterNamespace("foo");
+        assertFalse(asList(nsReg.getPrefixes()).contains("foo"));
+        assertFalse(asList(nsReg.getURIs()).contains(testNamespaceName1));
+        nsReg.registerNamespace("foo", testNamespaceName2);
+        assertTrue(asList(nsReg.getPrefixes()).contains("foo"));
+        assertTrue(asList(nsReg.getURIs()).contains(testNamespaceName2));
+
+        try {
+            session.getRootNode().getNode("{" + testNamespaceName1 + "}test");
+        } catch (PathNotFoundException expected) {
+            // we expect that this fails as the namespace name has been removed
+        }
+
+        // after remapping, the node created earlier is stil accessible with the
+        // name prefix, but the expanded name has changed
+        Node x3 = session.getRootNode().getNode("{" + testNamespaceName2 + "}test");
+        Node x4 = session.getRootNode().getNode("foo:test");
+        assertTrue(x3.isSame(x4));
+
+        nsReg.unregisterNamespace("foo");
+
+        session.getRootNode().getNode("foo:test").remove();
+        session.save();
+    }
+
     @Test
     public void sessionRemappedNamespace() throws RepositoryException {
         NamespaceRegistry nsReg =