[IOTDB-2671][metrics] Improve the implementation of iotdbReporter#5338
Merged
SteveYurongSu merged 23 commits intoapache:masterfrom Mar 27, 2022
Merged
[IOTDB-2671][metrics] Improve the implementation of iotdbReporter#5338SteveYurongSu merged 23 commits intoapache:masterfrom
SteveYurongSu merged 23 commits intoapache:masterfrom
Conversation
added 21 commits
March 17, 2022 16:26
Contributor
Author
|
@SteveYurongSu PTAL! |
Member
Hi, great! Please resolve the conflict :D |
added 2 commits
March 25, 2022 15:23
…orter_impl # Conflicts: # metrics/dropwizard-metrics/src/main/java/org/apache/iotdb/metrics/dropwizard/MetricName.java # metrics/dropwizard-metrics/src/main/java/org/apache/iotdb/metrics/dropwizard/reporter/DropwizardMetricsExporter.java
Contributor
Author
Ok, I resolve the conflict. |
Contributor
|
LGTM |
SteveYurongSu
approved these changes
Mar 27, 2022
Member
SteveYurongSu
left a comment
SteveYurongSu
left a comment
There was a problem hiding this comment.
LGTM.
Maybe we can use SessionPool instead of Session for fault tolerance. This can be a new ticket for u.
SpriCoder
added a commit
to SpriCoder/iotdb
that referenced
this pull request
Mar 28, 2022
…ache#5338) (cherry picked from commit c6e47b9)
SpriCoder
pushed a commit
to SpriCoder/iotdb
that referenced
this pull request
Mar 28, 2022
…ache#5338) (cherry picked from commit c6e47b9)
SteveYurongSu
pushed a commit
that referenced
this pull request
Apr 2, 2022
…pdate the implementation of IoTDBReporter and fix NPE error. (#5358) * [IOTDB-2777][metrics] Fix NPE and sample frequency (#5304) Co-authored-by: 还真 <huanzhen.gy@alibaba-inc.com> (cherry picked from commit b9b32e1) * [IOTDB-2762][metrics] Fix inconsistent name between dropwizard implementation and micrometer implementation (#5301) (cherry picked from commit 8f9d829) * [IOTDB-2671][metrics] Improve the implementation of iotdbReporter (#5338) (cherry picked from commit c6e47b9) * [IOTDB-2786][Dependency] remove iotdb-session dependent on iotdb-server(test) (#5319) (cherry picked from commit 3dca44a) * [IOTDB-2671][metrics] Improve the implementation of iotdbReporter (#5338) (cherry picked from commit c6e47b9) Co-authored-by: xinzhongtianxia <453935989@qq.com>
xinzhongtianxia
pushed a commit
to xinzhongtianxia/iotdb
that referenced
this pull request
Apr 5, 2022
…er_meta * remotes/upstream/master: Rename SchemaEngine to LocalSchemaProcessor and Rename SchemaRegionManager to SchemaEngine (apache#5359) Add SchemaRegion Interfaces to SchemaEngine (apache#5349) [IOTDB-2803] adapt metadata write operation to plannode (apache#5344) [IOTDB-2679] Support logical operators in select clauses (apache#5273) [IOTDB-2671][metrics] Improve the implementation of iotdbReporter (apache#5338) # Conflicts: # server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/LogicalPlanner.java # server/src/test/java/org/apache/iotdb/db/mpp/sql/plan/LogicalPlannerTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See more details:https://issues.apache.org/jira/browse/IOTDB-2671.