Refactor the todf() function of client-py to improve performance#4242
Refactor the todf() function of client-py to improve performance#4242SteveYurongSu merged 7 commits intoapache:masterfrom
Conversation
|
Hi, @JulianFeinauer Please take a look :D |
|
Thanks for pinging me @SteveYurongSu . The code looks so far fine for me. What wee are generally missing in our python module are tests (we effectively have none). So I really would appreciate any test (based on pytest) to be added to the repo. What do you think @fuwei3140 ? |
|
This is a good proposal, and a complete test is necessary @JulianFeinauer . I can try to use pytest to implement tests on various data type queries. @SteveYurongSu |
Great! |
|
Hello @JulianFeinauer @SteveYurongSu , |
…ting a dataframe exception
JulianFeinauer
left a comment
There was a problem hiding this comment.
Thank you very much, I feel a lot better now about this code!
…ting a dataframe exception.
|
fix a bug |
SteveYurongSu
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution!
I made some minor changes by executing black .(autoformatting) and flake8 .(linting) respectively.
Description
Optimized the processing logic of the todf() function in client_py to read the byte stream by column to avoid performance problems caused by reading by row.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR