Support build project by jdk25 #17118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CritasWang
reviewed
Jan 30, 2026
Collaborator
CritasWang
left a comment
CritasWang
left a comment
There was a problem hiding this comment.
This PR will encourage everyone to switch their main development version to version 17 or above
| @@ -1569,9 +1569,9 @@ | |||
| </profile> | |||
| <!-- Current version of spotless cannot support JDK11 below --> | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| <!-- Current version of spotless cannot support JDK11 below --> | |
| <!-- Current version of spotless cannot support JDK17 below --> |
Contributor
Author
There was a problem hiding this comment.
Yes, with jdk lower than 17, developers will skip the spotless check when execute mvn clean package.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17118 +/- ##
============================================
- Coverage 39.43% 39.42% -0.01%
Complexity 282 282
============================================
Files 5097 5097
Lines 341013 341013
Branches 43407 43407
============================================
- Hits 134475 134458 -17
- Misses 206538 206555 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation and build configuration to reflect expanded support for Java versions up to 25 and updates the Google Java Format tool version. The changes ensure that users and contributors are aware of the broader Java compatibility and that the build tooling is kept up to date.
Documentation updates:
README.mdandREADME_ZH.mdto indicate support for Java 1.8 and above, with explicit verification up to Java 25. [1] [2] [3] [4]Build configuration updates:
google.java.format.versionproperty inpom.xmlfrom1.22.0to1.28.0for improved code formatting support.pom.xmlto apply the.java-17-belowprofile for JDK versions below 17, instead of the previous.java-11-belowfor JDK versions up to 11.