Show procedures #15892
Show procedures #15892
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This query SQL is SHOW PROCUDURES |
|
It is a great job. Please rename the State column to Status, because the State of a Procedure is defined otherwise. I want to add two more columns to the result: Since every procedure has its State, the State column should be added to all procedures (maybe as a common method in the base class). |
2. Add two more columns to the result:State、Progress
|
Could you please provide a screenshot with the newest columns? |
@jt2594838 this is a screenshot with the newest columns.
|
|
One last thing, could you add an integration test for this? |
|
Hello @glutouny, glad to see this PR! I’ve just started reviewing it. So far, I feel that the |
| @@ -64,7 +64,7 @@ ddlStatement | |||
| | showVariables | showCluster | showRegions | showDataNodes | showConfigNodes | showClusterId | |||
| | getRegionId | getTimeSlotList | countTimeSlotList | getSeriesSlotList | |||
| | migrateRegion | reconstructRegion | extendRegion | removeRegion | removeDataNode | removeConfigNode | |||
| | verifyConnection | |||
| | verifyConnection | showProcedures | |||
There was a problem hiding this comment.
Maybe move this define to line 64, stay with other SHOW statement?
| Procedure<ConfigNodeProcedureEnv> procedure = procedureEntry.getValue(); | ||
| procedureInfo.setProcId(procedureEntry.getKey()); | ||
| procedureInfo.setStatus(procedure.getState().name()); | ||
| procedureInfo.setSubmittedTime(procedure.getSubmittedTime()); | ||
| procedureInfo.setLastUpdate(procedure.getLastUpdate()); | ||
| procedureInfo.setParentProcId(procedure.getParentProcId()); | ||
| procedureInfo.setClassName(procedure.getClass().getName()); | ||
| procedureInfo.setState(procedure.getCurrentStateForDisplay()); | ||
| procedureInfo.setProgress(procedure.getProgressForDisplay()); |
There was a problem hiding this comment.
Add a function like toTProcedureInfo() to Procedure.java ?
| protected IConfigTask visitShowProcedures( | ||
| final ShowProcedures showProceduresStatement, final MPPQueryContext context) { | ||
| context.setQueryType(QueryType.READ); | ||
| accessControl.checkUserIsAdmin(context.getSession().getUserName()); | ||
| return new ShowProcedureTask(); | ||
| } |
There was a problem hiding this comment.
Other SHOW statements are generally use the MAINTAIN privilege, I suggest referring to that here.
There was a problem hiding this comment.
Besides, the privilege control of new SQL needs to add IT, take a look at the function testClusterManagementSql
This PR mainly adds the Show Procedures feature: