Skip to content

Disable the parameter 'ALLOW_ZERO-BYTE_CITE_SIDED_PROPERTY1 NAME' and fix null pointer exception. #15866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HTHou merged 1 commit into from
Jul 3, 2025
Merged

Disable the parameter 'ALLOW_ZERO-BYTE_CITE_SIDED_PROPERTY1 NAME' and fix null pointer exception. #15866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/mqtt/MPPPublishHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ public String getID() {

@Override
public void onConnect(InterceptConnectMessage msg) {
if (msg.getClientID() == null || msg.getClientID().trim().isEmpty()) {
LOG.error(
"Connection refused: client_id is missing or empty. A valid client_id is required to establish a connection.");
}
if (!clientIdToSessionMap.containsKey(msg.getClientID())) {
MqttClientSession session = new MqttClientSession(msg.getClientID());
sessionManager.login(
Expand Down
6 changes: 4 additions & 2 deletions ...apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3650,8 +3650,10 @@ public SettableFuture<ConfigTaskResult> dropDatabase(
}

public static void unsetDatabaseIfNotExist(final String database, final IClientSession session) {
if (database.equals(session.getDatabaseName())) {
session.setDatabaseName(null);
if (session != null) {
if (database.equals(session.getDatabaseName())) {
session.setDatabaseName(null);
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/MQTTService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ private IConfig createBrokerConfig(IoTDBConfig iotDBConfig) {
BrokerConstants.DATA_PATH_PROPERTY_NAME, String.valueOf(iotDBConfig.getMqttDataPath()));
properties.setProperty(BrokerConstants.IMMEDIATE_BUFFER_FLUSH_PROPERTY_NAME, "true");
properties.setProperty(BrokerConstants.ALLOW_ANONYMOUS_PROPERTY_NAME, "false");
properties.setProperty(BrokerConstants.ALLOW_ZERO_BYTE_CLIENT_ID_PROPERTY_NAME, "true");
properties.setProperty(BrokerConstants.ALLOW_ZERO_BYTE_CLIENT_ID_PROPERTY_NAME, "false");
properties.setProperty(
BrokerConstants.NETTY_MAX_BYTES_PROPERTY_NAME,
String.valueOf(iotDBConfig.getMqttMaxMessageSize()));
Expand Down
Loading