Skip to content

Pipe: Fixed the NPE caused by the compression timer #15782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveYurongSu merged 1 commit into from
Jun 19, 2025
Merged

Pipe: Fixed the NPE caused by the compression timer #15782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .../main/java/org/apache/iotdb/confignode/manager/pipe/agent/task/PipeConfigNodeSubtask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@
import org.apache.iotdb.commons.pipe.agent.task.subtask.PipeAbstractConnectorSubtask;
import org.apache.iotdb.commons.pipe.config.constant.PipeProcessorConstant;
import org.apache.iotdb.commons.pipe.config.plugin.configuraion.PipeTaskRuntimeConfiguration;
import org.apache.iotdb.commons.pipe.config.plugin.env.PipeTaskConnectorRuntimeEnvironment;
import org.apache.iotdb.commons.pipe.config.plugin.env.PipeTaskExtractorRuntimeEnvironment;
import org.apache.iotdb.commons.pipe.config.plugin.env.PipeTaskRuntimeEnvironment;
import org.apache.iotdb.commons.pipe.config.plugin.env.PipeTaskProcessorRuntimeEnvironment;
import org.apache.iotdb.commons.pipe.event.EnrichedEvent;
import org.apache.iotdb.commons.pipe.event.ProgressReportEvent;
import org.apache.iotdb.confignode.manager.pipe.agent.PipeConfigNodeAgent;
Expand Down Expand Up @@ -117,7 +118,8 @@ private void initProcessor(final Map<String, String> processorAttributes) {

final PipeTaskRuntimeConfiguration runtimeConfiguration =
new PipeTaskRuntimeConfiguration(
new PipeTaskRuntimeEnvironment(pipeName, creationTime, CONFIG_REGION_ID.getId()));
new PipeTaskProcessorRuntimeEnvironment(
pipeName, creationTime, CONFIG_REGION_ID.getId(), null));

processor =
PipeConfigNodeAgent.plugin()
Expand All @@ -142,7 +144,8 @@ private void initConnector(final Map<String, String> connectorAttributes) throws
// 3. Customize connector
final PipeTaskRuntimeConfiguration runtimeConfiguration =
new PipeTaskRuntimeConfiguration(
new PipeTaskRuntimeEnvironment(pipeName, creationTime, CONFIG_REGION_ID.getId()));
new PipeTaskConnectorRuntimeEnvironment(
pipeName, creationTime, CONFIG_REGION_ID.getId()));
outputPipeConnector.customize(connectorParameters, runtimeConfiguration);

// 4. Handshake
Expand Down
2 changes: 1 addition & 1 deletion ...va/org/apache/iotdb/db/pipe/connector/protocol/airgap/IoTDBDataRegionAirGapConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ protected byte[] getTransferMultiFilePieceBytes(

@Override
protected byte[] compressIfNeeded(final byte[] reqInBytes) throws IOException {
if (Objects.isNull(compressionTimer)) {
if (Objects.isNull(compressionTimer) && Objects.nonNull(attributeSortedString)) {
compressionTimer =
PipeDataRegionConnectorMetrics.getInstance().getCompressionTimer(attributeSortedString);
}
Expand Down
2 changes: 1 addition & 1 deletion ...g/apache/iotdb/db/pipe/connector/protocol/thrift/async/IoTDBDataRegionAsyncConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ private void transferBatchedEventsIfNecessary() throws IOException, WriteProcess

@Override
public TPipeTransferReq compressIfNeeded(final TPipeTransferReq req) throws IOException {
if (Objects.isNull(compressionTimer)) {
if (Objects.isNull(compressionTimer) && Objects.nonNull(attributeSortedString)) {
compressionTimer =
PipeDataRegionConnectorMetrics.getInstance().getCompressionTimer(attributeSortedString);
}
Expand Down
2 changes: 1 addition & 1 deletion ...org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataRegionSyncConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ private void doTransfer(

@Override
public TPipeTransferReq compressIfNeeded(final TPipeTransferReq req) throws IOException {
if (Objects.isNull(compressionTimer)) {
if (Objects.isNull(compressionTimer) && Objects.nonNull(attributeSortedString)) {
compressionTimer =
PipeDataRegionConnectorMetrics.getInstance().getCompressionTimer(attributeSortedString);
}
Expand Down
Loading