Skip to content

Pipe: Add retry when TsFile parsing failed to avoid race among processor threads #15624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveYurongSu merged 1 commit into from
May 30, 2025
Merged

Pipe: Add retry when TsFile parsing failed to avoid race among processor threads #15624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions ...node/src/main/java/org/apache/iotdb/db/pipe/agent/task/connection/PipeEventCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package org.apache.iotdb.db.pipe.agent.task.connection;

import org.apache.iotdb.commons.exception.pipe.PipeRuntimeOutOfMemoryCriticalException;
import org.apache.iotdb.commons.pipe.agent.task.connection.UnboundedBlockingPendingQueue;
import org.apache.iotdb.commons.pipe.agent.task.progress.PipeEventCommitManager;
import org.apache.iotdb.commons.pipe.datastructure.pattern.IoTDBTreePattern;
Expand All @@ -41,6 +42,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.util.Iterator;
import java.util.concurrent.atomic.AtomicInteger;

public class PipeEventCollector implements EventCollector {
Expand Down Expand Up @@ -142,8 +144,31 @@ private void parseAndCollectEvent(final PipeTsFileInsertionEvent sourceEvent) th
}

try {
for (final TabletInsertionEvent parsedEvent : sourceEvent.toTabletInsertionEvents()) {
collectParsedRawTableEvent((PipeRawTabletInsertionEvent) parsedEvent);
final Iterable<TabletInsertionEvent> iterable = sourceEvent.toTabletInsertionEvents();
final Iterator<TabletInsertionEvent> iterator = iterable.iterator();
while (iterator.hasNext()) {
final TabletInsertionEvent parsedEvent = iterator.next();
int retryCount = 0;
while (true) {
try {
collectParsedRawTableEvent((PipeRawTabletInsertionEvent) parsedEvent);
break;
} catch (final PipeRuntimeOutOfMemoryCriticalException e) {
if (retryCount++ % 100 == 0) {
LOGGER.warn(
"parseAndCollectEvent: failed to allocate memory for parsing TsFile {}, retry count is {}, will keep retrying.",
sourceEvent.getTsFile(),
retryCount,
e);
} else if (LOGGER.isDebugEnabled()) {
LOGGER.debug(
"parseAndCollectEvent: failed to allocate memory for parsing TsFile {}, retry count is {}, will keep retrying.",
sourceEvent.getTsFile(),
retryCount,
e);
}
}
}
}
} finally {
sourceEvent.close();
Expand Down
Loading