Skip to content

avoid external memory space supplied when wal mode is disabled #15476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HTHou merged 8 commits into from
May 8, 2025
Merged

avoid external memory space supplied when wal mode is disabled #15476

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fad9ecd
fix: if wal mode is disabled, don't acquire wal buffer memory at all
zerolbsony May 7, 2025
4e737f5
Revert "fix: if wal mode is disabled, don't acquire wal buffer memory…
zerolbsony May 7, 2025
ba2e170
fix: if wal mode is disabled, wal buffer memory is no longer need to …
zerolbsony May 7, 2025
ea2a259
Revert "fix: if wal mode is disabled, wal buffer memory is no longer …
zerolbsony May 8, 2025
9b1fabc
fix: if wal mode is disabled, wal buffer memory is no longer need to …
zerolbsony May 8, 2025
ed3c39a
Merge branch 'master' into fix-wal-disabled-but-remain-acquire-mem
zerolbsony May 8, 2025
1202954
Merge branch 'apache:master' into master
zerolbsony May 8, 2025
ec22352
format code by use mvn spotless:apply
zerolbsony May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3884,7 +3884,8 @@ private static long getAcquireDirectBufferMemCost() {
long acquireDirectBufferMemCost = 0;
if (config.getDataRegionConsensusProtocolClass().equals(ConsensusFactory.IOT_CONSENSUS)
|| config.getDataRegionConsensusProtocolClass().equals(ConsensusFactory.IOT_CONSENSUS_V2)) {
acquireDirectBufferMemCost = config.getWalBufferSize();
acquireDirectBufferMemCost =
config.getWalMode().equals(WALMode.DISABLE) ? 0 : config.getWalBufferSize();
} else if (config
.getDataRegionConsensusProtocolClass()
.equals(ConsensusFactory.RATIS_CONSENSUS)) {
Expand Down
Loading