Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ConfigNode ConsensusManager init logic #12098

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

OneSizeFitsQuorum
Copy link
Contributor

By splitting the creation and launch of consensusManager, we avoid some redundant code.

We can now ensure that consensusManager.get () is never null when notifyLeaderReady is invoked

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Collaborator

@liyuheng55555 liyuheng55555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Collaborator

@Caideyipi Caideyipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@CRZbulabula CRZbulabula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 458efdb into master Feb 29, 2024
34 of 37 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the consensusManager_init branch February 29, 2024 06:56
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants