Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-7784][Tool] Support parallel compilation and packaging #9116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huanzhang
Copy link
Contributor

Prepare a Pull Request

Motivation

When using mvn -B or mvnd to compile the project, various problems will occur and the compilation will fail. The CR pipeline runs too slowly.

Reasons why parallel packaging cannot be done?

  1. The inlong-distribution module uses assembly to compress and package the output of each module together. However, the module dependencies are not clearly specified in the pom file, causing maven to infer dependencies.
  2. CR pipeline does not need to generate distribution

Modifications

  1. Remove package Distribution from CR pipeline
  2. Clear distribution modules and all dependencies in the project

@github-actions github-actions bot added the service/ci Automatically confirm that the code is error-free label Oct 26, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @huanzhang, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍

@@ -107,25 +105,3 @@ jobs:
run: |
version=`mvn -Dexec.executable='echo' -Dexec.args='${project.version}' --non-recursive exec:exec -q`
echo "VERSION=${version}" >> $GITHUB_ENV

- name: Upload binary package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me, but how can we upload the binary package after removing it?

Copy link

github-actions bot commented Jan 5, 2024

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stage/stale Issues or PRs that had no activity for a long time label Jan 5, 2024
@github-actions github-actions bot removed the stage/stale Issues or PRs that had no activity for a long time label Jul 19, 2024
Copy link

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stage/stale Issues or PRs that had no activity for a long time label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/ci Automatically confirm that the code is error-free stage/stale Issues or PRs that had no activity for a long time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Tool] Support parallel compilation and packaging
2 participants