Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9010][Sort] Add hive connector for flink1.15 #9030

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

huasiy
Copy link

@huasiy huasiy commented Oct 8, 2023

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @huasiy, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍

@dockerzhang dockerzhang changed the title add hive connector for flink1.15 [INLONG-9010][Sort] Add hive connector for flink1.15 Oct 8, 2023
@EMsnap
Copy link
Contributor

EMsnap commented Oct 12, 2023

Please add some tests on this connector thx

<thrift.version>0.9.3</thrift.version>
<kafka-clients.version>2.7.1</kafka-clients.version>
<flink-connector-debezium.version>2.3.0</flink-connector-debezium.version>
<flink-connector-hive.version>2.12</flink-connector-hive.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this version used for

@@ -52,9 +52,11 @@
<flink.protobuf.version>2.7.6</flink.protobuf.version>
<sqlserver.jdbc.version>7.2.2.jre8</sqlserver.jdbc.version>
<hudi.version>0.12.3</hudi.version>
<hive.version>3.1.3</hive.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hive3 version property has been defined in root pom


@Override
public String factoryIdentifier() {
return HiveCatalogFactoryOptions.IDENTIFIER;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use IDENTIFIER "hive-inlong"

@@ -31,49 +31,47 @@

<properties>
<inlong.root.dir>${project.parent.parent.parent.parent.basedir}</inlong.root.dir>
<hive.version>3.1.3</hive.version>
Copy link
Contributor

@vernedeng vernedeng Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to define duplicated hive version properties

Copy link

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stage/stale Issues or PRs that had no activity for a long time label Dec 12, 2023
@github-actions github-actions bot removed the stage/stale Issues or PRs that had no activity for a long time label Jul 19, 2024
Copy link

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stage/stale Issues or PRs that had no activity for a long time label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/manager component/sort stage/stale Issues or PRs that had no activity for a long time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Add Hive connector on flink 1.15
3 participants