Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10773][Sort] Refactor dependency structure to solve format-base could not compile on flink 1.18 env #10775

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

XiaoYou201
Copy link
Contributor

@XiaoYou201 XiaoYou201 commented Aug 12, 2024

[INLONG-10773][Sort] Refactor dependency structure to solve format-base could not compile on flink 1.18 env

Fixes #10773

Motivation

The format-base module can't compile on flink 1.18 env

But connector-base dependense it, so the dependency structure need to refactor

ProjectedDeserializationSchemaFactory.java, ProjectedSerializationSchemaFactory.java,
TableFormatDeserializerFactory.java , TableFormatSerializerFactory.java extends TableFormatFactory.java,
But TableFormatFactory was deprecated in flink 1.18, So, it will be failed in compile on flink 1.18 env.

Modifications

  • Move TimestampedCollector to format-common module
  • Refactor dependency structure

Verifying this change

mvn --update-snapshots -e -V verify -pl :sort-connector-pulsar-v1.18 -am -Pv1.18

Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format-base module can't compile on flink 1.18 env

-》

Please add reasons of this on the description ( Like there are classes not available or changed on flink 1.18)

@aloyszhang aloyszhang merged commit ef20f56 into apache:master Aug 13, 2024
12 checks passed
emptyOVO pushed a commit to emptyOVO/inlong that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Sort] The format-base module can't compile on flink 1.18 env
3 participants