Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10768][Sort] Csv utils support specified the max split field size #10769

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

vernedeng
Copy link
Contributor

@vernedeng vernedeng commented Aug 9, 2024

Fixes #10768

Motivation

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    In the case that the input string is

"name|age=20\||&'\n\name|age=20\||&'\n\n|home|\home\"

  1. max size = 0
image
  1. max size = 1
image
  1. max size = 2
image
  1. max size = 3
image
  1. max size = 4
image
  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng added this to the 1.14.0 milestone Aug 9, 2024
@vernedeng vernedeng self-assigned this Aug 9, 2024
@dockerzhang dockerzhang merged commit e50f45b into apache:master Aug 11, 2024
10 checks passed
emptyOVO pushed a commit to emptyOVO/inlong that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Csv utils support specified the max split field size
4 participants