Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10053][Sort] Support flink-connector-pulsar based on flink 1.18 #10063

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

aloyszhang
Copy link
Contributor

@aloyszhang aloyszhang commented Apr 24, 2024

Fixes #10053

Motivation

Add support of pulsar connectors for flink 1.18

Modifications

  • create new modules for connectors-v1.18 and connector-pulsar-v1.18
  • make sure PulsarTableOptions is compatible with PulsarExtractNode

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (no)

Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image please add a assemble file for this connector

Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image please keep artifact name consistent

baomingyu
baomingyu previously approved these changes Apr 24, 2024
Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a workflow also
image

Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: support audit metrics when receiving messages

@aloyszhang
Copy link
Contributor Author

aloyszhang commented Apr 24, 2024

image please add a assemble file for this connector

Thanks for your suggestion.
I planned to add assembling works in a separate pull request, see #10057.
Processing the assembling and GitHub workflow in this pull request makes sense to me also.
Will finish them soon.

@aloyszhang
Copy link
Contributor Author

TODO: support audit metrics when receiving messages

I'll bring another pull request to deal with audit metrics.

EMsnap
EMsnap previously approved these changes Apr 24, 2024
@aloyszhang aloyszhang dismissed stale reviews from EMsnap and baomingyu via 092b8ea April 24, 2024 10:27
@github-actions github-actions bot added the service/ci Automatically confirm that the code is error-free label Apr 24, 2024
EMsnap
EMsnap previously approved these changes Apr 24, 2024
baomingyu
baomingyu previously approved these changes Apr 24, 2024
@dockerzhang
Copy link
Contributor

@aloyszhang please update the licenses.

@aloyszhang aloyszhang dismissed stale reviews from baomingyu and EMsnap via d508b58 April 24, 2024 11:13
@dockerzhang dockerzhang merged commit 4db62df into apache:master Apr 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sort service/ci Automatically confirm that the code is error-free
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Support flink-connector-pulsar based on flink 1.18
4 participants