Repository navigation
Conversation
Previously, autolink_jira entries could only be added, never removed. The autolink directive now treats autolink_jira as the authoritative list of Jira autolinks for the repository: - Removing an entry from autolink_jira deletes that autolink - Removing the whole autolink_jira section deletes all Jira autolinks - Jira autolinks created by other means (e.g. via INFRA ticket) are removed if not in the list; autolinks pointing anywhere else than the ASF Jira are never touched - If autolink_jira has never been configured (not present in the current nor the previously applied .asf.yaml), nothing happens Also fixes a bug where autolinks were created without specifying is_alphanumeric, which defaults to true on the GitHub API, making e.g. SOLR-FOO match the autolink. Autolinks are now created with is_alphanumeric=false so only numeric ticket ids (SOLR-123) match, and existing autolinks with the wrong setting are recreated. Fixes apache#115
|
I hope this can fix an issue seen in this comment apache/solr-mcp#160 (comment) where plain text in a PR comment like As you can see, removing it did not remove the auto-link, which will be fixed by this PR. Also, this PR will fix the alpha-numeric issue, so that only numeric issue refs will be linked. I think there may also be another bug regarding case sensitivity - it should not have linked lowercase |
|
Thanks for the review @ppkarwasz , anyone wants to merge? |
|
Sandbox-tested this against my own sandbox repo (rebased onto current Seeded three autolinks beforehand to cover each branch of the new logic, then applied
Run: https://github.com/potiuk/infrastructure-asfyaml/actions/runs/35316394422 One path I could not exercise: removing |
Previously, autolink_jira entries could only be added, never removed. The autolink directive now treats autolink_jira as the authoritative list of Jira autolinks for the repository:
Also fixes a bug where autolinks were created without specifying is_alphanumeric, which defaults to true on the GitHub API, making e.g. SOLR-FOO match the autolink. Autolinks are now created with is_alphanumeric=false so only numeric ticket ids (SOLR-123) match, and existing autolinks with the wrong setting are recreated.
Fixes #115