Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[551] Remove dependencies in LICENSE and NOTICE files based on feedback in LEGAL-684 #566

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

vinishjail97
Copy link
Contributor

@vinishjail97 vinishjail97 commented Oct 17, 2024

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

The final outcome from https://issues.apache.org/jira/browse/LEGAL-684 advises to not include dependencies from other ASF projects in LICENSE and NOTICE files.

Brief change log

(for example:)

  • Updated LICENSE and NOTICE files to reflect feedback LEGAL-684

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

Copy link
Contributor

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Based on the feedback in LEGAL-684 I suppose we can remove them also from the LICENSE file.

@jcamachor
Copy link
Contributor

Thanks, @vinishjail97 ! Should we remove the addendum from LICENSE file as well?

@vinishjail97
Copy link
Contributor Author

Squashed into a single commit.

@vinishjail97 vinishjail97 changed the title [551] Remove dependencies in NOTICE file based on feedback in LEGAL-684 [551] Remove dependencies in LICENSE and NOTICE files based on feedback in LEGAL-684 Oct 24, 2024
@vinishjail97 vinishjail97 merged commit 4f04bd7 into main Oct 24, 2024
2 checks passed
@vinishjail97 vinishjail97 deleted the 551-NOTICE branch October 24, 2024 13:30
@vinishjail97 vinishjail97 mentioned this pull request Oct 31, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants