Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[530] xtable-core pom has a hardcoded scala version for jackson-module-scala #537

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

rangareddy
Copy link
Contributor

Important Read

This pull request aims to address issues #530

What is the purpose of the pull request

Removing the hardcoded scala version for jackson-module-scala in xtable parent project and xtable-core projects.

Brief change log

  • Removed the hard coded scala version i.e 2.12 and replaced with ${scala.version.prefix}.
<dependency>
    <groupId>com.fasterxml.jackson.module</groupId>
    <artifactId>jackson-module-scala_${scala.version.prefix}</artifactId>
    <version>${jackson.version}</version>
</dependency>

Verify this pull request

Verified by running $ mvn clean install -DskipTests -U locally.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vinishjail97 vinishjail97 merged commit f96ee21 into apache:main Sep 17, 2024
2 checks passed
@vinishjail97 vinishjail97 mentioned this pull request Oct 3, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants