Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[531] xtable poms are missing license details. #533

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

rangareddy
Copy link
Contributor

@rangareddy rangareddy commented Sep 10, 2024

Important Read

This pull request aims to address issue #531

What is the purpose of the pull request

Adding the tag to xtable project and updating the project name.

Brief change log

  • Added the and in the xtable parent project
<licenses>
    <license>
        <name>Apache License, Version 2.0</name>
        <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
        <distribution>repo</distribution>
    </license>
</licenses>

<organization>
    <name>The Apache Software Foundation</name>
    <url>https://www.apache.org</url>
</organization>
  • Updated the project name for each module, for example
<name>XTable Parent Project</name>

Verify this pull request

Verified by running $ mvn clean install -DskipTests -U locally.

pom.xml Outdated

<groupId>org.apache.xtable</groupId>
<artifactId>xtable</artifactId>
<name>xtable</name>
<name>XTable Parent Project</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change ?

Copy link
Contributor Author

@rangareddy rangareddy Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will displays the project name clearly while building the xtable. You can refer Spark code for reference.

[INFO] XTable Parent Project .............................. SUCCESS [  0.316 s]
[INFO] XTable Api Project ................................. SUCCESS [  0.032 s]
[INFO] XTable Hudi Support Parent Project ................. SUCCESS [  0.025 s]
[INFO] XTable Hudi Support Utils Project .................. SUCCESS [  0.019 s]
[INFO] XTable Core Project ................................ SUCCESS [  0.036 s]
[INFO] XTable Utilities Project ........................... SUCCESS [  0.014 s]
[INFO] XTable Hudi Support Extensions Project ............. SUCCESS [  0.015 s]
[INFO] ------------------------------------------------------------------------

xtable-api/pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@vinishjail97
Copy link
Contributor

@rangareddy Can you update the PR description to [531] xtable poms are missing license details. according to guidelines ?

@rangareddy rangareddy changed the title Fix for 531 - xtable poms are missing license details [531] xtable poms are missing license details. Sep 10, 2024
@rangareddy
Copy link
Contributor Author

Hi @vinishjail97 Merge this PR to main branch.

@vinishjail97 vinishjail97 merged commit 814da69 into apache:main Sep 16, 2024
2 checks passed
@vinishjail97 vinishjail97 mentioned this pull request Oct 3, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants