Skip to content
This repository was archived by the owner on Jun 3, 2021. It is now read-only.

* [Android] Add more log for list component's column count. #1957

Merged
merged 1 commit into from
Dec 24, 2018
Merged

* [Android] Add more log for list component's column count. #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXListComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import android.support.v4.util.ArrayMap;
import android.support.v7.widget.PagerSnapHelper;
import android.text.TextUtils;

import com.alibaba.fastjson.JSON;
import com.taobao.weex.WXSDKInstance;
import com.taobao.weex.annotation.Component;
Expand All @@ -46,8 +45,8 @@
import com.taobao.weex.utils.WXExceptionUtils;
import com.taobao.weex.utils.WXLogUtils;
import com.taobao.weex.utils.WXUtils;

import java.lang.reflect.InvocationTargetException;
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.Map;
Expand Down Expand Up @@ -176,6 +175,8 @@ private void updateRecyclerAttr() {
if (mColumnCount <= 0 && mLayoutType != TYPE_LINEAR_LAYOUT) {
Map<String, String> ext = new ArrayMap<>();
ext.put("componentType", getComponentType());
ext.put("attribute", getAttrs().toString());
ext.put("stackTrace", Arrays.toString(Thread.currentThread().getStackTrace()));
WXExceptionUtils.commitCriticalExceptionRT(getInstanceId(),
WXErrorCode.WX_RENDER_ERR_LIST_INVALID_COLUMN_COUNT, "columnCount",
String.format(Locale.ENGLISH,
Expand Down
3 changes: 3 additions & 0 deletions .../sdk/src/main/java/com/taobao/weex/ui/component/list/template/WXRecyclerTemplateList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
import com.taobao.weex.utils.WXUtils;
import com.taobao.weex.utils.WXViewUtils;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Locale;
Expand Down Expand Up @@ -934,6 +935,8 @@ private void updateRecyclerAttr(){
if (mColumnCount <= 0 && mLayoutType != TYPE_LINEAR_LAYOUT) {
Map<String, String> ext = new ArrayMap<>();
ext.put("componentType", getComponentType());
ext.put("attribute", getAttrs().toString());
ext.put("stackTrace", Arrays.toString(Thread.currentThread().getStackTrace()));
WXExceptionUtils.commitCriticalExceptionRT(getInstanceId(),
WXErrorCode.WX_RENDER_ERR_LIST_INVALID_COLUMN_COUNT, "columnCount",
String.format(Locale.ENGLISH,
Expand Down