This repository was archived by the owner on Jun 3, 2021. It is now read-only.
[devtool] Updated the Apache release scripts. #1741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'npm run build:rax' to generate Rax precompiled js files, and updated the build command and generated project for iOS.
|
@YorkShen @Hanks10100 @cxfeng1 PTAL. thanks. |
Generated by 🚫 dangerJS |
Hanks10100
reviewed
Nov 13, 2018
|
|
||
| echo "Weex JS Framework build completed." | ||
| sleep 2 | ||
|
|
||
| mkdir pre-build | ||
| # Copy built JS resources to their destination. | ||
| [ -d pre-build ] || mkdir pre-build | ||
| cp dist/weex-js-framework.min.js pre-build/native-bundle-main.js | ||
| cp dist/weex-js-framework.min.js android_sdk/assets/native-bundle-main.js |
There was a problem hiding this comment.
I think the file structure had been refactored, here should be android/sdk/assets instead of android_sdk/assets.
There was a problem hiding this comment.
This is on purpose because not all the changes in the source code base are suitable for Apache Release, so we created a dedicated directory and copy the necessary sources into it.
There was a problem hiding this comment.
Got it! I mixed up those folders.
Hanks10100
reviewed
Nov 13, 2018
| @@ -40,10 +42,12 @@ cp dist/weex-polyfill.min.js pre-build/weex-polyfill.js | |||
| cp dist/weex-rax.min.js pre-build/weex-rax-api.js | |||
| cp dist/weex-rax.min.js android_sdk/assets/weex-rax-api.js | |||
|
|
|||
| # Build android_sdk | |||
| gradle wrapper --gradle-version 4.4 | |||
| echo 'include ":android_sdk"'>settings.gradle | |||
| ./gradlew :android_sdk:assemble -PasfRelease | |||
There was a problem hiding this comment.
Should we get into the android path before running these commands?
There was a problem hiding this comment.
same reason as above.
Hanks10100
approved these changes
Nov 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'npm run build:rax' to generate Rax precompiled js files, and
updated the build command and generated project for iOS.