[MINOR] chore(operator): remove useless configuration items in configuration example #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
============================================
+ Coverage 60.67% 60.69% +0.02%
- Complexity 1901 1904 +3
============================================
Files 239 239
Lines 13031 13038 +7
Branches 1091 1093 +2
============================================
+ Hits 7907 7914 +7
+ Misses 4686 4683 -3
- Partials 438 441 +3 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Mar 25, 2023
| @@ -42,11 +42,8 @@ data: | |||
| log4j.appender.RollingAppender.layout=org.apache.log4j.PatternLayout | |||
| log4j.appender.RollingAppender.layout.ConversionPattern=[%p] %d %t %c{1} %M - %m%n | |||
| server.conf: |- | |||
| rss.coordinator.quorum rss-coordinator-rss-demo-0:19997,rss-coordinator-rss-demo-1:19997 | |||
There was a problem hiding this comment.
How about make this configuration commented out? such as
# these configurations are generated by operator automatically
# rss.coordinator.quorum rss-coordinator-rss-demo-0:19997,rss-coordinator-rss-demo-1:19997
# ...
advancedxy
approved these changes
Mar 27, 2023
xianjingfeng
added a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…uration example (apache#764) ### What changes were proposed in this pull request? Remove useless configuration items in configuration example. ### Why are the changes needed? The configuration items that removed will be generated automatically. Setting them has no effect. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? No need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove useless configuration items in configuration example.
Why are the changes needed?
The configuration items that removed will be generated automatically. Setting them has no effect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need