[#1764] fix(client): Fix timeout time unit for unregister requests #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally, the truth is revealed. Good! |
EnricoMi
added a commit
that referenced
this pull request
Jun 4, 2024
…1766) ### What changes were proposed in this pull request? Method `ThreadUtils.executeTasks` expects milliseconds, but seconds are given. ### Why are the changes needed? Requests are interrupted before the configured timeout passes. Fix: #1764 ### Does this PR introduce _any_ user-facing change? Configured timeout is respected. ### How was this patch tested? Manually tested.
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Method
ThreadUtils.executeTasksexpects milliseconds, but seconds are given.Why are the changes needed?
Requests are interrupted before the configured timeout passes.
Fix: #1764
Does this PR introduce any user-facing change?
Configured timeout is respected.
How was this patch tested?
Manually tested.