Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1459][FOLLOWUP] improvement(server): Print an error log when an event is dropped #1643

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

rickyma
Copy link
Contributor

@rickyma rickyma commented Apr 11, 2024

What changes were proposed in this pull request?

Print an error log when an event is dropped.

Why are the changes needed?

A follow-up PR for: #1461.
This way, it's easier to find error logs in the log, making it convenient for troubleshooting.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unnecessary.

Copy link

Test Results

 2 363 files  ±0   2 363 suites  ±0   4h 31m 3s ⏱️ -8s
   912 tests ±0     911 ✅ ±0   1 💤 ±0  0 ❌ ±0 
10 585 runs  ±0  10 571 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit b1f71f8. ± Comparison against base commit ed39955.

@jerqi jerqi merged commit 5ad9f48 into apache:master Apr 13, 2024
41 checks passed
@rickyma rickyma deleted the pr-1461-followup branch May 5, 2024 08:33
jerqi pushed a commit that referenced this pull request May 6, 2024
…nt is dropped (#1643)

### What changes were proposed in this pull request?

Print an error log when an event is dropped.

### Why are the changes needed?

A follow-up PR for: #1461.
This way, it's easier to find error logs in the log, making it convenient for troubleshooting.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unnecessary.
jerqi pushed a commit that referenced this pull request May 6, 2024
…#1672)

### What changes were proposed in this pull request?

Fix the issue of log variable printing.

### Why are the changes needed?

Cherry pick commits #1643 and #1648 from master to branch-0.9.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants