Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1549] fix(common): Uniformly throw RssException for external callers #1550

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

rickyma
Copy link
Contributor

@rickyma rickyma commented Feb 28, 2024

What changes were proposed in this pull request?

Make custom exception classes in the rss-common module inherit from RssException.

Why are the changes needed?

For #1549

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

@rickyma
Copy link
Contributor Author

rickyma commented Feb 28, 2024

@jerqi @zuston PTAL.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.57%. Comparing base (12f9271) to head (b1884f9).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1550      +/-   ##
============================================
+ Coverage     53.61%   54.57%   +0.96%     
- Complexity     2815     2816       +1     
============================================
  Files           436      416      -20     
  Lines         24536    22175    -2361     
  Branches       2076     2076              
============================================
- Hits          13155    12103    -1052     
+ Misses        10560     9322    -1238     
+ Partials        821      750      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

2 312 files  + 50  2 312 suites  +50   4h 37m 45s ⏱️ + 14m 5s
  823 tests ±  0    822 ✅ +  1   1 💤 ±0  0 ❌  - 1 
9 693 runs  +159  9 679 ✅ +160  14 💤 ±0  0 ❌  - 1 

Results for commit b1884f9. ± Comparison against base commit 12f9271.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerqi jerqi merged commit d4c0fc5 into apache:master Feb 28, 2024
41 checks passed
@rickyma rickyma deleted the use-rssexception branch May 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants