Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1464][FOLLOWUP] improvement(spark): print abnormal shuffle servers that blocks fail to send #1473

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

rickyma
Copy link
Contributor

@rickyma rickyma commented Jan 19, 2024

What changes were proposed in this pull request?

The output of failed shuffle servers' result has not been successfully deduplicated.

Why are the changes needed?

It's a followup PR for #1465.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

@rickyma
Copy link
Contributor Author

rickyma commented Jan 19, 2024

Sorry for my mistake in #1465 . PTAL again. @jerqi @zuston

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bcaf9e) 54.01% compared to head (6060c21) 55.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1473      +/-   ##
============================================
+ Coverage     54.01%   55.00%   +0.98%     
- Complexity     2776     2777       +1     
============================================
  Files           427      407      -20     
  Lines         24324    21963    -2361     
  Branches       2072     2072              
============================================
- Hits          13139    12081    -1058     
+ Misses        10368     9137    -1231     
+ Partials        817      745      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerqi jerqi merged commit ca0f0ac into apache:master Jan 22, 2024
36 checks passed
@rickyma rickyma deleted the issue-1464-followup branch May 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants