Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] improvement: use mvn wrapper for builds #1345

Merged
merged 3 commits into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .mvn/wrapper/maven-wrapper.jar
Binary file not shown.
18 changes: 18 additions & 0 deletions .mvn/wrapper/maven-wrapper.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar
20 changes: 10 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,43 +80,43 @@ Currently supports the MapReduce framework of Hadoop 2.8.5, Hadoop 3.2.1
Uniffle is built using [Apache Maven](https://maven.apache.org/).
To build it, run:

mvn -DskipTests clean package
./mvnw -DskipTests clean package

To fix code style issues, run:

mvn spotless:apply -Pspark3 -Pspark2 -Ptez -Pmr -Phadoop2.8
./mvnw spotless:apply -Pspark3 -Pspark2 -Ptez -Pmr -Phadoop2.8

Build against profile Spark 2 (2.4.6)

mvn -DskipTests clean package -Pspark2
./mvnw -DskipTests clean package -Pspark2

Build against profile Spark 3 (3.1.2)

mvn -DskipTests clean package -Pspark3
./mvnw -DskipTests clean package -Pspark3

Build against Spark 3.2.x, Except 3.2.0

mvn -DskipTests clean package -Pspark3.2
./mvnw -DskipTests clean package -Pspark3.2

Build against Spark 3.2.0

mvn -DskipTests clean package -Pspark3.2.0
./mvnw -DskipTests clean package -Pspark3.2.0

Build against Hadoop MapReduce 2.8.5

mvn -DskipTests clean package -Pmr,hadoop2.8
./mvnw -DskipTests clean package -Pmr,hadoop2.8

Build against Hadoop MapReduce 3.2.1

mvn -DskipTests clean package -Pmr,hadoop3.2
./mvnw -DskipTests clean package -Pmr,hadoop3.2

Build against Tez 0.9.1

mvn -DskipTests clean package -Ptez
./mvnw -DskipTests clean package -Ptez

Build against Tez 0.9.1 and Hadoop 3.2.1

mvn -DskipTests clean package -Ptez,hadoop3.2
./mvnw -DskipTests clean package -Ptez,hadoop3.2

To package the Uniffle, run:

Expand Down
2 changes: 1 addition & 1 deletion build_distribution.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ set -x
set -u

NAME="rss"
MVN="mvn"
MVN="./mvnw"
RSS_HOME="$(
cd "$(dirname "$0")"
pwd
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/docker/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ fi

RSS_DIR=../../..
cd $RSS_DIR || exit
RSS_VERSION=$(mvn help:evaluate -Dexpression=project.version 2>/dev/null | grep -v "INFO" | grep -v "WARNING" | tail -n 1)
RSS_VERSION=$(./mvnw help:evaluate -Dexpression=project.version 2>/dev/null | grep -v "INFO" | grep -v "WARNING" | tail -n 1)
RSS_FILE=rss-${RSS_VERSION}-hadoop${HADOOP_SHORT_VERSION}.tgz
echo "RSS_VERSION: $RSS_VERSION"
echo "RSS_FILE: $RSS_FILE"
Expand Down
2 changes: 1 addition & 1 deletion docs/gen-doc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ set -e

BASE_DIR="$(cd "`dirname "$0"`/.."; pwd)"
cd "${BASE_DIR}"
mvn clean javadoc:aggregate
./mvnw clean javadoc:aggregate
mv target/site/apidocs docs
cd docs

Expand Down
Loading