[#1290] improvement(operator): Avoid accidentally deleting data of other services when misconfiguring the mounting directory #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
============================================
- Coverage 53.83% 53.75% -0.08%
Complexity 2691 2691
============================================
Files 401 401
Lines 23418 23419 +1
Branches 1992 1992
============================================
- Hits 12606 12590 -16
- Misses 10036 10054 +18
+ Partials 776 775 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Nov 2, 2023
|
@zhengchenyu Could you help review this pr? |
advancedxy
approved these changes
Nov 18, 2023
xianjingfeng
pushed a commit
that referenced
this pull request
Nov 20, 2023
…her services when misconfiguring the mounting directory (#1291) ### What changes were proposed in this pull request? Only delete `rssdata` directory. ### Why are the changes needed? Fix: #1290 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested in our cluster. 1. Mount `/data/hdfs1/rssdata1` dir for shuffle server，the server will create `/data/hdfs1/rssdata1/rssdata/` 2. Create files manually at host machine ``` touch /data/hdfs1/rssdata1/a.txt touch /data/hdfs1/rssdata1/rssdata/b.txt ``` 3. Update crd to terminate this shuffle server. 4. Without this pr, both `a.txt`, `b.txt` and `rssdata` dir are deleted 5. With this pr, only `b.txt` is deleted Co-authored-by: 齐家乐(26731624) <qijiale001@ke.com> (cherry picked from commit be10697)
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
… of other services when misconfiguring the mounting directory (apache#1291) ### What changes were proposed in this pull request? Only delete `rssdata` directory. ### Why are the changes needed? Fix: apache#1290 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested in our cluster. 1. Mount `/data/hdfs1/rssdata1` dir for shuffle server，the server will create `/data/hdfs1/rssdata1/rssdata/` 2. Create files manually at host machine ``` touch /data/hdfs1/rssdata1/a.txt touch /data/hdfs1/rssdata1/rssdata/b.txt ``` 3. Update crd to terminate this shuffle server. 4. Without this pr, both `a.txt`, `b.txt` and `rssdata` dir are deleted 5. With this pr, only `b.txt` is deleted Co-authored-by: 齐家乐(26731624) <qijiale001@ke.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Only delete
rssdatadirectory.Why are the changes needed?
Fix: #1290
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested in our cluster.
/data/hdfs1/rssdata1dir for shuffle server，the server will create/data/hdfs1/rssdata1/rssdata/a.txt,b.txtandrssdatadir are deletedb.txtis deleted