[#1177] improvement: Reduce the write time of tasks #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
============================================
+ Coverage 53.63% 54.74% +1.10%
Complexity 2582 2582
============================================
Files 391 371 -20
Lines 22407 20047 -2360
Branches 1875 1875
============================================
- Hits 12019 10975 -1044
+ Misses 9681 8436 -1245
+ Partials 707 636 -71 see 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
client-spark/spark3/src/main/java/org/apache/spark/shuffle/writer/RssShuffleWriter.java
Outdated
Show resolved
Hide resolved
zuston
reviewed
Aug 30, 2023
| blockIds.removeAll(successBlockIds); | ||
| if (blockIds.isEmpty()) { | ||
| break; | ||
| boolean interrupted = false; |
There was a problem hiding this comment.
It looks complex for current implement.
And I think the sendTimeout is wrong, which is valid for all everytime queue.poll
There was a problem hiding this comment.
We use remainingMs instead of sendCheckTImeout.
zuston
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use callback and queue to optimize the write time.
Why are the changes needed?
Fix: #1177
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI passed.