[#960][part-3] feat(dashboard): Provides a start-stop script for the dashboard. #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
============================================
+ Coverage 53.47% 54.41% +0.94%
Complexity 2695 2695
============================================
Files 411 391 -20
Lines 23644 21283 -2361
Branches 2006 2006
============================================
- Hits 12643 11581 -1062
+ Misses 10225 8997 -1228
+ Partials 776 705 -71 ☔ View full report in Codecov by Sentry. |
yl09099
force-pushed
the
uniffle-960-3
branch
from
200a340 to
57c35ad
Compare
yl09099
force-pushed
the
uniffle-960-3
branch
from
9f7a28c to
e45add2
Compare
|
@jerqi @xianjingfeng @leixm Please look at it for me. |
dashboard/src/main/java/org/apache/uniffle/dashboard/web/config/DashboardConf.java
Outdated
Show resolved
Hide resolved
dashboard/src/main/java/org/apache/uniffle/dashboard/web/JettyServerFront.java
Outdated
Show resolved
Hide resolved
dashboard/src/main/java/org/apache/uniffle/dashboard/web/proxy/WebProxyServlet.java
Outdated
Show resolved
Hide resolved
| return null; | ||
| } | ||
| StringBuilder target = new StringBuilder(); | ||
| String targetUri = "http://" + hostAndPort + "/"; |
There was a problem hiding this comment.
May use https
None of the servers support https, so that's not necessary.
There was a problem hiding this comment.
yl09099
force-pushed
the
uniffle-960-3
branch
2 times, most recently
from
4d91c6a to
04fd4af
Compare
| @@ -30,6 +30,12 @@ public class DashboardConf extends RssBaseConf { | |||
| .defaultValue(19988) | |||
| .withDescription("http server http port"); | |||
|
|
|||
| public static final ConfigOption<String> COORDINATOR_JETTY_ADDRESS = | |||
| ConfigOptions.key("coordinator.jetty.address") | |||
There was a problem hiding this comment.
Is it possible that we will not use jetty in the future？Or we don’t use java to implement coordinator? How about coordinator.web.address or coordinator.address?
There was a problem hiding this comment.
Is it possible that we will not use jetty in the future？Or we don’t use java to implement coordinator? How about coordinator.web.address or coordinator.address?
OK.
yl09099
force-pushed
the
uniffle-960-3
branch
3 times, most recently
from
35e497d to
a55609c
Compare
| } else { | ||
| targetUri = "http://" + targetAddress + "/"; | ||
| } | ||
| if (targetUri.endsWith("/")) { |
| HandlerList handlers = new HandlerList(); | ||
| ResourceHandler resourceHandler = addResourceHandler(); | ||
| String coordinatorWebAddress = conf.getString(DashboardConf.COORDINATOR_WEB_ADDRESS); | ||
| boolean sslEnable = conf.getBoolean(DashboardConf.JETTY_SSL_ENABLE, false); |
There was a problem hiding this comment.
Reusing JETTY_SSL_ENABLE is weird. Could you add a new parameter? Such as coodinator.ssl.enable. Or change the format of COORDINATOR_WEB_ADDRESS to http://host:port/
yl09099
force-pushed
the
uniffle-960-3
branch
from
a55609c to
60f13d9
Compare
yl09099
force-pushed
the
uniffle-960-3
branch
from
60f13d9 to
814bb6d
Compare
xianjingfeng
approved these changes
Nov 22, 2023
|
Merged. Thanks @yl09099 |
jerqi
pushed a commit
that referenced
this pull request
Dec 5, 2023
…he dashboard. (#1346) ### What changes were proposed in this pull request? Fix get_pid_file_name function for the dashboard. ### Why are the changes needed? This is the follow up pr of [#1056](#1056) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the script: start-dashboard.sh and stop-dashboard.sh.
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
…r the dashboard. (apache#1056) ### What changes were proposed in this pull request? Provides a start-stop script for the dashboard. ### Why are the changes needed? Fix: apache#960 ### Does this PR introduce any user-facing change? Start and close the dashboard module using shell scripts. ### How was this patch tested? UT.
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
… for the dashboard. (apache#1346) ### What changes were proposed in this pull request? Fix get_pid_file_name function for the dashboard. ### Why are the changes needed? This is the follow up pr of [apache#1056](apache#1056) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the script: start-dashboard.sh and stop-dashboard.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provides a start-stop script for the dashboard.
Why are the changes needed?
(Please clarify why the changes are needed. For instance,
Fix: #960
Does this PR introduce any user-facing change?
Start and close the dashboar module using shell scripts.
How was this patch tested?
UT.