Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The same heartbeat is missed while the heartbeat RPC takes a long time. #2188

Open
3 tasks done
xumanbu opened this issue Oct 16, 2024 · 0 comments · May be fixed by #2189
Open
3 tasks done

[Bug] The same heartbeat is missed while the heartbeat RPC takes a long time. #2188

xumanbu opened this issue Oct 16, 2024 · 0 comments · May be fixed by #2189

Comments

@xumanbu
Copy link
Contributor

xumanbu commented Oct 16, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

We've added some new nodes to our production environment, and sometimes these nodes experience RPC timeouts (that's a separate issue). This can cause a lot of tasks to fail, and the reason for the failures is that some nodes haven't received heartbeats for a long time, leading to the app data being cleared from the server.

We found that there's a bit of an issue with the timeoutMs in ShuffleWriteClientImpl#sendAppHeartbeat method. The timeoutMs for per RPC is similar to the timeoutMs of ThreadUtils#executeTasks` for all servers RPC execute, and the logic here is flawed.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
xumanbu added a commit to xumanbu/incubator-uniffle that referenced this issue Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant