Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect disk size for local storage #1678

Closed
3 tasks done
zuston opened this issue May 8, 2024 · 1 comment · Fixed by #1679
Closed
3 tasks done

[Bug] Incorrect disk size for local storage #1678

zuston opened this issue May 8, 2024 · 1 comment · Fixed by #1679

Comments

@zuston
Copy link
Member

zuston commented May 8, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

Currently, the disk size of localStorage's shuffleMeta is not descrease correctly when using appPurgeEvent to remove resources.
That will make the disk size collected by uniffle leak and then make the disk invalid.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@rickyma
Copy link
Contributor

rickyma commented May 8, 2024

When will the disk become invalid? I'm curious that I've never encountered this issue.

zuston added a commit that referenced this issue May 10, 2024
…Event (#1679)

### What changes were proposed in this pull request?

Descrease the disk size  that calculated by local storage self on removing resources with AppPurgeEvent

### Why are the changes needed?

Fix: #1678

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unit tests
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this issue May 10, 2024
…pPurgeEvent (apache#1679)

### What changes were proposed in this pull request?

Descrease the disk size  that calculated by local storage self on removing resources with AppPurgeEvent

### Why are the changes needed?

Fix: apache#1678

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unit tests

(cherry picked from commit ae72831)
zuston added a commit to zuston/incubator-uniffle that referenced this issue May 11, 2024
…pPurgeEvent (apache#1679)

### What changes were proposed in this pull request?

Descrease the disk size  that calculated by local storage self on removing resources with AppPurgeEvent

### Why are the changes needed?

Fix: apache#1678

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unit tests
zuston added a commit that referenced this issue May 11, 2024
…Event (#1679) (#1689)

### What changes were proposed in this pull request?

Descrease the disk size  that calculated by local storage self on removing resources with AppPurgeEvent

### Why are the changes needed?

Fix: #1678

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants