Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] The exception might be swallowed when there is a bug in the code while handling the FlushEvent #1588

Closed
3 tasks done
rickyma opened this issue Mar 18, 2024 · 0 comments
Closed
3 tasks done

[Bug] The exception might be swallowed when there is a bug in the code while handling the FlushEvent #1588

rickyma opened this issue Mar 18, 2024 · 0 comments

Comments

@rickyma
Copy link
Contributor

rickyma commented Mar 18, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

Currently, the thread pool handling the FlushEvent does not have exception handling in place. If there are unknown bugs in the subsequent code, exceptions might be swallowed, making it difficult to pinpoint the issue.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Mar 18, 2024
@rickyma
[apache#1588] improvement(server): Add exception handling for the thr…
9b22272 
…ead pool when flushing events
@rickyma rickyma mentioned this issue Mar 18, 2024
Merged
zuston pushed a commit that referenced this issue Mar 18, 2024
@rickyma
[#1588] improvement(server): Add exception handling for the thread po…
f3775a1 
…ol when flushing events (#1589)

### What changes were proposed in this pull request?

Add exception handling for the thread pool when flushing events.

### Why are the changes needed?

For #1588.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UTs.
@rickyma rickyma closed this as completed Mar 18, 2024
zuston pushed a commit to zuston/incubator-uniffle that referenced this issue May 27, 2024
@rickyma @zuston
[apache#1588] improvement(server): Add exception handling for the thr…
f9bb55c 
…ead pool when flushing events (apache#1589)

### What changes were proposed in this pull request?

Add exception handling for the thread pool when flushing events.

### Why are the changes needed?

For apache#1588.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UTs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rickyma