Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Exceptions might be discarded when spilling buffers #1572

Closed
3 tasks done
rickyma opened this issue Mar 13, 2024 · 0 comments · Fixed by #1573
Closed
3 tasks done

[Bug] Exceptions might be discarded when spilling buffers #1572

rickyma opened this issue Mar 13, 2024 · 0 comments · Fixed by #1573

Comments

@rickyma
Copy link
Contributor

rickyma commented Mar 13, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

A return statement inside a finally block will cause any exception that might be thrown in the try or catch block to be discarded.

I think we need to handle all the exceptions when spilling buffers.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Mar 13, 2024
@rickyma
[apache#1572] fix(spark): Exceptions might be discarded when spilling…
58de5d6 
… buffers
@rickyma rickyma mentioned this issue Mar 13, 2024
Merged
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Mar 13, 2024
@rickyma
[apache#1572] fix(spark): Exceptions might be discarded when spilling…
47f5747 
… buffers
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Mar 13, 2024
@rickyma
[apache#1572] fix(spark): Exceptions might be discarded when spilling…
8f258fa 
… buffers
@leslizhang leslizhang mentioned this issue Mar 13, 2024
Merged
zuston pushed a commit that referenced this issue Mar 14, 2024
@rickyma
[#1572] fix(spark): Exceptions might be discarded when spilling buffe…
b2baef5 
…rs (#1573)

### What changes were proposed in this pull request?

Handle all the exceptions when spilling buffers.
Let users know when a TimeoutException occurs.

### Why are the changes needed?

Fix #1572.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UTs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1572] fix(spark): Exceptions might be discarded when spilling buffers rickyma/incubator-uniffle
1 participant
@rickyma