Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] flushing buffer if the memoryUsed of the first record of WriterBuffer larger than bufferSize #1497

Closed
3 tasks done
xianjingfeng opened this issue Feb 1, 2024 · 0 comments · Fixed by #1485
Closed
3 tasks done

Comments

@xianjingfeng
Copy link
Member

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently in org.apache.spark.shuffle.writer.WriteBufferManager#insertIntoBuffer, if the memoryUsed of WriterBuffer larger than bufferSize, the WriterBuffer will be flush. But if the memoryUsed of the first record larger than bufferSize, the WriterBuffer will not be flush.

How should we improve?

Flushing buffer if the memoryUsed of the first record of WriterBuffer larger than bufferSize

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
zuston pushed a commit that referenced this issue Feb 1, 2024
…first record of `WriterBuffer` larger than bufferSize (#1485)

### What changes were proposed in this pull request?

Flushing buffer if the memoryUsed of the first record of `WriterBuffer` larger than bufferSize.

### Why are the changes needed?

More accurate. fix #1497 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

UT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant