-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Provide dedicated unregister app rpc interface #1476
Comments
cc @xianjingfeng @jerqi . WDYT? Whether to introduce new rpc or reusing the existing |
I think it is better to introduce new rpc interface. |
Kindly to ask if there is somebody working for this issue? If not, i'm glad to undertake it. |
Feel free. Assigned |
Signed-off-by: Yiqi You <2810592075@qq.com>
…1510) ### What changes were proposed in this pull request? Introduce dedicated unregisterApp rpc interface which is only called once when unregister shuffle ### Why are the changes needed? Fix: [#1476](#1476) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT
…face (apache#1510) ### What changes were proposed in this pull request? Introduce dedicated unregisterApp rpc interface which is only called once when unregister shuffle ### Why are the changes needed? Fix: [apache#1476](apache#1476) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT
Code of Conduct
Search before asking
Describe the feature
Motivation
I found the unregister app in shuffleManager stop method always is timeout when having too much stages. And there is no need to unregister shuffle one by one, why not introducing unregister app rpc method?
But I'm hesitant whether to reuse the unregisterShuffle rpc by making the shuffleId of protobuf optional to achieve the app purging
Describe the solution
No response
Additional context
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: