Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] add metrics of expired pre-allocated buffer size #1356

Open
2 of 3 tasks
zuston opened this issue Dec 7, 2023 · 2 comments · Fixed by #1412
Open
2 of 3 tasks

[FEATURE] add metrics of expired pre-allocated buffer size #1356

zuston opened this issue Dec 7, 2023 · 2 comments · Fixed by #1412
Labels
good first issue Good for newcomers

Comments

@zuston
Copy link
Member

zuston commented Dec 7, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

add metrics of expired pre-allocated buffer size

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zuston zuston added the good first issue Good for newcomers label Dec 7, 2023
@lifeSo lifeSo mentioned this issue Dec 30, 2023
Merged
zuston pushed a commit that referenced this issue Jan 5, 2024
@lifeSo
[#1356] improvement: add metric of total expired pre-allocated buffers (
7d59126 
#1412)

### What changes were proposed in this pull request?

Add metrics of expired pre-allocated buffer size

### Why are the changes needed?

For: #1356

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

test on PRD
@zuston zuston reopened this Jan 18, 2024
@zuston
Copy link
Member Author

zuston commented Jan 18, 2024

I don't know the reason of removing the metrics in #1425

zuston added a commit to zuston/incubator-uniffle that referenced this issue Jan 18, 2024
@zuston
[apache#1356] feat(server): improve expired buffers metric and log
1ca8c09
@zuston zuston mentioned this issue Jan 18, 2024
Merged
@lifeSo
Copy link
Collaborator

lifeSo commented Jan 22, 2024

I don't know the reason of removing the metrics in #1425

OK, anyway I will fix it recently.

jerqi pushed a commit that referenced this issue Jan 23, 2024
@zuston
[#1356] feat(server): improve expired buffers metric and log (#1469)
ba25785 
### What changes were proposed in this pull request?

improve expired buffers metric and log

Once the expired buffer happened, it means the server or client may have problems, 
we should find out the related apps by the log shown in the server

### Why are the changes needed?

For #1356 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1356] improvement: add metric of total expired pre-allocated buffers lifeSo/incubator-uniffle
2 participants
@zuston @lifeSo