Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] tez unit test RssShuffleTest #1254

Closed
2 of 3 tasks
summaryzb opened this issue Oct 23, 2023 · 2 comments · Fixed by #1255 or #1259
Closed
2 of 3 tasks

[Flaky Test] tez unit test RssShuffleTest #1254

summaryzb opened this issue Oct 23, 2023 · 2 comments · Fixed by #1255 or #1259

Comments

@summaryzb
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the flaky test

[INFO] Running org.apache.tez.runtime.library.common.shuffle.orderedgrouped.RssShuffleTest
Error:  Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.134 s <<< FAILURE! - in org.apache.tez.runtime.library.common.shuffle.orderedgrouped.RssShuffleTest
Error:  testSchedulerTerminatesOnException  Time elapsed: 0.074 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:40)
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:35)
	at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:227)
	at org.apache.tez.runtime.library.common.shuffle.orderedgrouped.RssShuffleTest.testSchedulerTerminatesOnException(RssShuffleTest.java:93)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)

Actions URL

https://github.com/apache/incubator-uniffle/actions/runs/6607344077/job/17944613341?pr=1253

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@summaryzb
Copy link
Contributor Author

@lifeSo please take a look, appreciated

@zhengchenyu
Copy link
Collaborator

zhengchenyu commented Oct 23, 2023

I also encountered this problem and prepare to fix it.

shuffle.run -> submit runnable to executor.
The runnable will call cleanupShuffleScheduler -> rssScheduler.close -> sShutdown.getAndSet(true)
So this is a random error.

If sleep 3s before 'assertFalse(scheduler.isShutdown())'. It is easy to reproduce this error.

zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Oct 23, 2023
jerqi pushed a commit that referenced this issue Oct 23, 2023
### What changes were proposed in this pull request?
As title.

### Why are the changes needed?

Fix: #1254 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

unit test
jerqi pushed a commit that referenced this issue Oct 23, 2023
### What changes were proposed in this pull request?
As title.

### Why are the changes needed?

Fix: #1254 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

unit test
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Oct 24, 2023
jerqi pushed a commit that referenced this issue Oct 24, 2023
### What changes were proposed in this pull request?

### Why are the changes needed?

Fix: #1254 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

unit test
xianjingfeng pushed a commit that referenced this issue Oct 31, 2023
### What changes were proposed in this pull request?

### Why are the changes needed?

Fix: #1254

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

unit test

(cherry picked from commit 3071099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants