Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Incorrect storage write fail metric #1252

Closed
3 tasks done
summaryzb opened this issue Oct 22, 2023 · 1 comment · Fixed by #1253
Closed
3 tasks done

[Bug] Incorrect storage write fail metric #1252

summaryzb opened this issue Oct 22, 2023 · 1 comment · Fixed by #1253

Comments

@summaryzb
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

Metric in incStorageFailedCounter may updates wrong, while using the wrong storageHost.
The storage under the event may have already changed, if incStorageFailedCounter is called after eventHandler.handle(event), since the event will be processed in another thread to do storage selection work.

Affects Version(s)

0.8

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
summaryzb added a commit to summaryzb/incubator-uniffle that referenced this issue Oct 22, 2023
@summaryzb
[apache#1252] fix(server): Incorrect storage write fail metric
8590725
summaryzb added a commit to summaryzb/incubator-uniffle that referenced this issue Oct 22, 2023
@summaryzb
[apache#1252] fix(server): Incorrect storage write fail metric
a5d9746
@summaryzb
Copy link
Contributor Author

summaryzb commented Oct 22, 2023 •
edited
Loading

It's just a thread safety problem

@summaryzb summaryzb mentioned this issue Oct 22, 2023
Merged
smallzhongfeng pushed a commit that referenced this issue Oct 25, 2023
@summaryzb
[#1252] fix(server): Incorrect storage write fail metric (#1253)
931d6cd 
What changes were proposed in this pull request?
As title

Why are the changes needed?
Fix: #1252

Does this PR introduce any user-facing change?
No.

How was this patch tested?
unit test
xianjingfeng pushed a commit that referenced this issue Oct 31, 2023
@summaryzb @xianjingfeng
[#1252] fix(server): Incorrect storage write fail metric (#1253)
bb56768 
What changes were proposed in this pull request?
As title

Why are the changes needed?
Fix: #1252

Does this PR introduce any user-facing change?
No.

How was this patch tested?
unit test

(cherry picked from commit 931d6cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1252] fix(server): Incorrect storage write fail metric summaryzb/incubator-uniffle
1 participant
@summaryzb