Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] support populating args by clap #1237

Closed
3 tasks done
zuston opened this issue Oct 16, 2023 · 0 comments · Fixed by #1236
Closed
3 tasks done

[FEATURE] support populating args by clap #1237

zuston opened this issue Oct 16, 2023 · 0 comments · Fixed by #1236
Labels
rust

Comments

@zuston
Copy link
Member

zuston commented Oct 16, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

Currently, the config path is specified by the environment key, which is not elegant.

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zuston zuston added the rust label Oct 16, 2023
@zuston zuston linked a pull request Oct 16, 2023 that will close this issue
[#1237] feat(rust): support populating args by clap #1236
Merged
zuston added a commit that referenced this issue Oct 17, 2023
@zuston
[#1237] feat(rust): support populating args by clap (#1236)
541388b 
### What changes were proposed in this pull request?

This PR is to support populating args by clap.

### Why are the changes needed?

Before this, the config path is specified by the environment key, which is not elegant. 

### Does this PR introduce _any_ user-facing change?

Yes

### How was this patch tested?

Existing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1237] feat(rust): support populating args by clap zuston/incubator-uniffle
1 participant
@zuston