Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add labels with disk path for local storage total_localfile_write_data metrics #1108

Closed
2 of 3 tasks
Tracked by #1092
, #2
...
zuston opened this issue Aug 7, 2023 · 2 comments · Fixed by #1160
Closed
2 of 3 tasks
Tracked by #1092
, #2
...

[FEATURE] Add labels with disk path for local storage total_localfile_write_data metrics #1108

zuston opened this issue Aug 7, 2023 · 2 comments · Fixed by #1160
Assignees
@zhuyaogai
Labels
good first issue Good for newcomers

Comments

@zuston
Copy link
Member

zuston commented Aug 7, 2023 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

Currently, the metric of total_localfile_write_data only shows the all disks data written. It's better to expose the every disk's uniffle data written size.

We could put the disk path as the label of total_localfile_write_data metrics

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zuston zuston added the good first issue Good for newcomers label Aug 7, 2023
@jerqi jerqi mentioned this issue Aug 8, 2023
Open
17 tasks
@zhuyaogai
Copy link
Contributor

@zuston Could you assign this issue to me?

@zuston
Copy link
Member Author

zuston commented Aug 14, 2023

@zuston Could you assign this issue to me?

Thanks. Pls go ahead

@zhuyaogai zhuyaogai mentioned this issue Aug 19, 2023
Merged
zuston pushed a commit that referenced this issue Aug 21, 2023
@zhuyaogai
[#1108] feat(server): Add labels with disk path for `total_localfile_…
4869630 
…write_data` metrics. (#1160)

### What changes were proposed in this pull request?

Add labels with disk path for local storage `total_localfile_write_data` metrics.

### Why are the changes needed?

Fix: #1108

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Add more unit test case.
@gdrbacca gdrbacca mentioned this issue Oct 27, 2023
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhuyaogai zhuyaogai

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@zuston @zhuyaogai