Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sgx_tunittest): remove the necessary 'std::panic' import for 'should_panic' macro #217

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Conversation

sammyne
Copy link

@sammyne sammyne commented Apr 4, 2020

Problem

The should_panic! macro in sgx_tunittest uses std::panic, which requires us the imports
std::panic every time we use should_panic!.

A demo project goes as patch-sgx_tunittest.

To verify, just comment out the patch section of Cargo.toml.

The project demonstrates the this inconvenience, and helps to support this patch.

The patch mainly add the std:: prefix to the panic function in use so as to avoid explicit
import of the std::panic every time.

Hope it helps~

@sammyne sammyne changed the title refactor(sgx_tunittest): remove the necessary 'std' import for 'should_panic' macro refactor(sgx_tunittest): remove the necessary 'std::panic' import for 'should_panic' macro Apr 4, 2020
@dingelish dingelish merged commit 66aaa28 into apache:master Apr 6, 2020
@dingelish
Copy link
Contributor

Thanks @sammyne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants