-
Notifications
You must be signed in to change notification settings - Fork 8.9k
optimize: add OkHttp and MockWebServer dependencies to resolve version confilcts #7934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
funky-eyes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please register your PR in those two files :
https://github.com/apache/incubator-seata/blob/2.x/changes/zh-cn/2.x.md
https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7934 +/- ##
============================================
+ Coverage 71.56% 71.62% +0.05%
Complexity 884 884
============================================
Files 1300 1300
Lines 49701 49701
Branches 5895 5895
============================================
+ Hits 35569 35598 +29
+ Misses 11212 11185 -27
+ Partials 2920 2918 -2 🚀 New features to boost your workflow:
|
I’ll register my PR in both files by today :) |
|
I've updated both files and committed the changes. |
maple525866
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you for your contributions to Seata. If possible, please send your Dingtalk contact information to my email, and I will invite you to join the Seata developer group. |
|
I’ve sent the email. |
Ⅰ. Describe what this PR did
okhttpversion 4.9.3 property declarationokhttpandmockwebserverto<dependencyManagement>section independencies/pom.xmlⅡ. Does this pull request fix one issue?
fixes #7920
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews