Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix typo #6823

Merged
merged 2 commits into from
Sep 11, 2024
Merged

optimize: fix typo #6823

merged 2 commits into from
Sep 11, 2024

Conversation

jbampton
Copy link
Member

@jbampton jbampton commented Sep 7, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.39%. Comparing base (fde59c1) to head (cd66c51).
Report is 5 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../apache/seata/tm/api/DefaultGlobalTransaction.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6823      +/-   ##
============================================
- Coverage     52.41%   52.39%   -0.02%     
- Complexity     6379     6381       +2     
============================================
  Files          1080     1080              
  Lines         37565    37565              
  Branches       4451     4451              
============================================
- Hits          19691    19684       -7     
- Misses        15923    15931       +8     
+ Partials       1951     1950       -1     
Files with missing lines Coverage Δ
.../apache/seata/tm/api/DefaultGlobalTransaction.java 61.73% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi
Copy link
Member

Please register this pr in changes.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/incubator-seata/blob/2.x/changes/zh-cn/2.x.md
https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md
请在上述md文件中登记pr信息和作者信息
Please register pr information and author information in the above md file

@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 8, 2024
@slievrly slievrly changed the title Fix typo optimize: fix typo Sep 8, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 6d941ee into apache:2.x Sep 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants