bugfix: change group and node offline status are not pushed in real time #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/zh-cn/2.x.md
funky-eyes
changed the title
funky-eyes
reviewed
Sep 4, 2024
namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java
Outdated
Show resolved
Hide resolved
funky-eyes
reviewed
Sep 4, 2024
namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java
Show resolved
Hide resolved
…er/NamingManager.java Co-authored-by: funkye <364176773@qq.com>
…er/NamingManager.java Co-authored-by: funkye <364176773@qq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6812 +/- ##
============================================
- Coverage 52.36% 52.29% -0.08%
+ Complexity 6393 6384 -9
============================================
Files 1080 1080
Lines 37546 37552 +6
Branches 4446 4449 +3
============================================
- Hits 19662 19638 -24
- Misses 15948 15978 +30
Partials 1936 1936
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.push to the client when the server node goes offline using namingserver
2.ensure consistency of addgroup and removegroup
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews